From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbbJMM1d (ORCPT ); Tue, 13 Oct 2015 08:27:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38115 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbbJMM1c (ORCPT ); Tue, 13 Oct 2015 08:27:32 -0400 Date: Tue, 13 Oct 2015 14:27:13 +0200 From: Peter Zijlstra To: Boqun Feng Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Will Deacon , "Paul E. McKenney" , Waiman Long , Davidlohr Bueso Subject: Re: [PATCH v3 0/6] atomics: powerpc: Implement relaxed/acquire/release variants of some atomics Message-ID: <20151013122713.GS3604@twins.programming.kicks-ass.net> References: <1444659246-24769-1-git-send-email-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444659246-24769-1-git-send-email-boqun.feng@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 10:14:00PM +0800, Boqun Feng wrote: > The patchset consists of 6 parts: > > 1. Make xchg, cmpxchg and their atomic_ versions a full barrier > > 2. Add trivial tests for the new variants in lib/atomic64_test.c > > 3. Allow architectures to define their own __atomic_op_*() helpers > to build other variants based on relaxed. > > 4. Implement atomic{,64}_{add,sub,inc,dec}_return_* variants > > 5. Implement xchg_* and atomic{,64}_xchg_* variants > > 6. Implement cmpxchg_* atomic{,64}_cmpxchg_* variants > > > This patchset is based on current locking/core branch of the tip tree > and all patches are built and boot tested for little endian pseries, and > also tested by 0day. > I don't see any immediate problems with this series at this point. Will, Paul?