From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932430AbbJMNnp (ORCPT ); Tue, 13 Oct 2015 09:43:45 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34513 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbbJMNnn (ORCPT ); Tue, 13 Oct 2015 09:43:43 -0400 Date: Tue, 13 Oct 2015 14:43:02 +0100 From: Lee Jones To: Charles Keepax Cc: cw00.choi@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, broonie@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection Message-ID: <20151013134302.GA32409@x1> References: <1443803363-3251-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1443803363-3251-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20151013080800.GY17172@x1> <20151013121530.GE8805@ck-lbox> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151013121530.GE8805@ck-lbox> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2015, Charles Keepax wrote: > On Tue, Oct 13, 2015 at 09:08:00AM +0100, Lee Jones wrote: > > On Fri, 02 Oct 2015, Charles Keepax wrote: > > > > > Add additional bindings to allow configuration of the system specific > > > microphone detection settings. > > > > > > Signed-off-by: Charles Keepax > > > --- > > > Documentation/devicetree/bindings/mfd/arizona.txt | 21 +++++++++++++++++++++ > > > include/dt-bindings/mfd/arizona.h | 5 +++++ > > > 2 files changed, 26 insertions(+), 0 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > > > index a8fee60..b98a11b 100644 > > > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > > > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > > > @@ -73,6 +73,27 @@ Optional properties: > > > If this node is not mentioned or if the value is unknown, then > > > headphone detection mode is set to HPDETL. > > > > > > + - wlf,micd-software-compare : Use a software comparison to determine mic > > > + presence > > > + - wlf,micd-detect-debounce : Additional software microphone detection > > > + debounce specified in milliseconds. > > > + - wlf,micd-pol-gpio : GPIO specifier for the GPIO controlling the headset > > > + polarity if one exists. > > > + - wlf,micd-bias-start-time : Time allowed for MICBIAS to startup prior to > > > + performing microphone detection, specified as per the ARIZONA_MICD_TIME_XXX > > > + defines. > > > + - wlf,micd-rate : Delay between successive microphone detection measurements, > > > + specified as per the ARIZONA_MICD_TIME_XXX defines. > > > + - wlf,micd-dbtime : Microphone detection hardware debounces specified as the > > > + number of measurements to take, valid values being 2 and 4. > > > + - wlf,micd-timeout : Timeout for microphone detection, specified in > > > + milliseconds. > > > + - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone > > > + detection. > > > + > > > + - wlf,gpsw : Settings for the general purpose switch, set as one of the > > > + ARIZONA_GPSW_XXX defines. > > > > Where are all of these bindings to be consumed? > > In the extcon driver it handles all jack detection in the Arizona > devices. Okay, perfect. Please move them to the Extcon doc. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog