From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbbJMN7e (ORCPT ); Tue, 13 Oct 2015 09:59:34 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35109 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbbJMN7d (ORCPT ); Tue, 13 Oct 2015 09:59:33 -0400 Date: Tue, 13 Oct 2015 15:59:26 +0200 From: Richard Cochran To: "Christopher S. Hall" Cc: jeffrey.t.kirsher@intel.com, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, john.stultz@linaro.org, peterz@infradead.org, x86@kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kevin.b.stanton@intel.com Subject: Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping Message-ID: <20151013135925.GB5422@localhost.localdomain> References: <1444675522-4198-1-git-send-email-christopher.s.hall@intel.com> <1444675522-4198-4-git-send-email-christopher.s.hall@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444675522-4198-4-git-send-email-christopher.s.hall@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote: > > +struct ptp_sys_offset_precise { > + unsigned int rsv[4]; /* Reserved for future use. */ > + struct ptp_clock_time dev; > + struct ptp_clock_time sys; > +}; > + Please put the reserved field at the bottom. Also, since we reading the raw monotonic time under the hood, we might as well return it in this struct too. It costs us almost nothing, and having that value can be useful for characterizing the system oscillator. Thanks, Richard