Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

Richard Cochran
2015-10-13T13:59:34Z

On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote:
>
> +struct ptp_sys_offset_precise {
> + unsigned int rsv[4]; /* Reserved for future use. */
> + struct ptp_clock_time dev;
> + struct ptp_clock_time sys;
> +};
> +

Please put the reserved field at the bottom. Also, since we reading
the raw monotonic time under the hood, we might as well return it in
this struct too. It costs us almost nothing, and having that value
can be useful for characterizing the system oscillator.

Thanks,
Richard