Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

Christopher Hall
2015-10-15T02:47:35Z

On Tue, 13 Oct 2015 06:59:26 -0700, Richard Cochran
<richardcochran@gmail.com> wrote:

> On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote:
>>
>> +struct ptp_sys_offset_precise {
>> + unsigned int rsv[4]; /* Reserved for future use. */
>> + struct ptp_clock_time dev;
>> + struct ptp_clock_time sys;
>> +};
>> +
>
> Please put the reserved field at the bottom. Also, since we reading
> the raw monotonic time under the hood, we might as well return it in

Good idea.

Thanks,
Chris