From: Frederic Weisbecker <fweisbec@gmail.com>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Subject: Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load
Date: Tue, 13 Oct 2015 16:55:02 +0200 [thread overview]
Message-ID: <20151013145501.GB14876@lerouge> (raw)
In-Reply-To: <20151013083718.GT6455@byungchulpark-X58A-UD3R>
On Tue, Oct 13, 2015 at 05:37:18PM +0900, Byungchul Park wrote:
> > > find out the pending updates from update_process_times() itself and pass
> > > it to scheduler_tick() which is the one interested in it.
> >
> > tick_nohz_handler() calls tick_sched_handler() ?!
> >
> > And tick_nohz_handler() actually computes the number of ticks -- which
> > we then happily ignore.
> >
> > Why compute it again a few functions down?
>
> i think so.
>
> additionally, i think it would be better to assume that scheduler_tick()
> handles 1 tick as peter said e.g. because of virt, and to handle the
> case caused by full NOHZ *in the nohz related code*.
You mean "not to assume" right?
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-10-13 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 7:46 [PATCH v3 0/2] sched: consider missed ticks when updating cpu load byungchul.park
2015-10-02 7:46 ` [PATCH v3 1/2] sched: make __update_cpu_load() handle active tickless case byungchul.park
2015-10-02 7:46 ` [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load byungchul.park
2015-10-02 15:59 ` Peter Zijlstra
2015-10-04 6:58 ` Byungchul Park
2015-10-05 8:15 ` Peter Zijlstra
2015-10-12 17:45 ` Frederic Weisbecker
2015-10-13 7:04 ` Peter Zijlstra
2015-10-13 8:37 ` Byungchul Park
2015-10-13 14:55 ` Frederic Weisbecker [this message]
2015-10-13 14:51 ` Frederic Weisbecker
2015-10-13 14:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013145501.GB14876@lerouge \
--to=fweisbec@gmail.com \
--cc=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox