From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753206AbbJMO4X (ORCPT ); Tue, 13 Oct 2015 10:56:23 -0400 Received: from casper.infradead.org ([85.118.1.10]:56416 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbbJMO4W (ORCPT ); Tue, 13 Oct 2015 10:56:22 -0400 Date: Tue, 13 Oct 2015 16:56:19 +0200 From: Peter Zijlstra To: Frederic Weisbecker Cc: Byungchul Park , mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load Message-ID: <20151013145619.GT3816@twins.programming.kicks-ass.net> References: <1443771974-27077-1-git-send-email-byungchul.park@lge.com> <1443771974-27077-3-git-send-email-byungchul.park@lge.com> <20151002155906.GD3816@twins.programming.kicks-ass.net> <20151004065819.GS6455@byungchulpark-X58A-UD3R> <20151005081555.GF2903@worktop.programming.kicks-ass.net> <20151012174532.GB1113@lerouge> <20151013070436.GO3604@twins.programming.kicks-ass.net> <20151013145102.GA14876@lerouge> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151013145102.GA14876@lerouge> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 04:51:05PM +0200, Frederic Weisbecker wrote: > > And tick_nohz_handler() actually computes the number of ticks -- which > > we then happily ignore. > > > > Why compute it again a few functions down? > > Ah, you mean we could get the return value of hrtimer_foward()? Both > callers use hrtimer_forward() and I think it's fine to call it before > tick_sched_handle(). Indeed so!