From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113AbbJMPI6 (ORCPT ); Tue, 13 Oct 2015 11:08:58 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36099 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbbJMPI4 (ORCPT ); Tue, 13 Oct 2015 11:08:56 -0400 Date: Tue, 13 Oct 2015 20:38:41 +0530 From: Viresh Kumar To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kevin Hilman , Olof Johansson , Arnd Bergmann , Heiko Stuebner , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Message-ID: <20151013150841.GZ5386@linux> References: <1444743164-17735-2-git-send-email-sudeep.holla@arm.com> <1444747133-22671-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444747133-22671-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-10-15, 15:38, Sudeep Holla wrote: > Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy > "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup > source. > > Few dts files assign value "1" to gpio-key,wakeup and in one instance a > value "0" is assigned probably assuming it won't be enabled as a wakeup > source. Since the presence of the boolean property indicates it is > enabled, value of "0" have no value. > > This patch replaces the legacy "gpio-key,wakeup" with the unified > "wakeup-source" property which inturn fixes the above mentioned issue. > > Cc: Heiko Stuebner > Cc: linux-rockchip@lists.infradead.org > Cc: Viresh Kumar > Signed-off-by: Sudeep Holla > --- > arch/arm/boot/dts/spear1310-evb.dts | 2 +- > arch/arm/boot/dts/spear1340-evb.dts | 2 +- > arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- Reviewed-by: Viresh Kumar -- viresh