From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbJMTZz (ORCPT ); Tue, 13 Oct 2015 15:25:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:40055 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbbJMTZv (ORCPT ); Tue, 13 Oct 2015 15:25:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,679,1437462000"; d="scan'208";a="826123316" Date: Tue, 13 Oct 2015 22:25:47 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, "open list:KEYS-TRUSTED" , "open list:KEYS-TRUSTED" Subject: Re: [PATCH v2 0/4] Basic trusted keys support for TPM 2.0 Message-ID: <20151013192547.GA3669@intel.com> References: <1444723889-11650-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20151013174120.GC22160@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151013174120.GC22160@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 11:41:20AM -0600, Jason Gunthorpe wrote: > On Tue, Oct 13, 2015 at 11:11:21AM +0300, Jarkko Sakkinen wrote: > > > * I updated tpm_buf to a be heap based structure. Now there's one full > > page of memory for variable sized messages. Also the stack is greatly > > reduced. > > You may as well just use a skb then. struct sk_buff?? I think the structure that I've implemented is a good fit. It's simple to use and does exactly what we need. Can you elaborate what's the problem with tpm_buf? > Jason /Jarkko