From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbbJMUbj (ORCPT ); Tue, 13 Oct 2015 16:31:39 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56639 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753031AbbJMUbh (ORCPT ); Tue, 13 Oct 2015 16:31:37 -0400 Date: Tue, 13 Oct 2015 13:31:34 -0700 From: Guenter Roeck To: Lukasz Odzioba Cc: fenghua.yu@intel.com, jdelvare@suse.de, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Bumps limit of maximum core ID from 32 to 128. Message-ID: <20151013203134.GA28106@roeck-us.net> References: <1444650812-17398-1-git-send-email-lukasz.odzioba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444650812-17398-1-git-send-email-lukasz.odzioba@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2015 at 01:53:32PM +0200, Lukasz Odzioba wrote: > A new limit selected arbitrarily as power of two greater than > required minimum for Xeon Phi processor. > > Currently driver is not able to handle cores with core ID greater than 32. > Such attempt ends up with the following error in dmesg: > coretemp coretemp.0: Adding Core XXX failed > Why 128 instead of a more reasonable 64 ? What is the required minimum for Xeon Phi ? Also, please consider using the subject line commonly used in hwmon, or at least point to the driver you are changing. Thanks, Guenter > Signed-off-by: Lukasz Odzioba > --- > drivers/hwmon/coretemp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c > index 3e03379..6a27eb2 100644 > --- a/drivers/hwmon/coretemp.c > +++ b/drivers/hwmon/coretemp.c > @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444); > MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius"); > > #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */ > -#define NUM_REAL_CORES 32 /* Number of Real cores per cpu */ > +#define NUM_REAL_CORES 128 /* Number of Real cores per cpu */ > #define CORETEMP_NAME_LENGTH 19 /* String Length of attrs */ > #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */ > #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1) > -- > 1.7.1 >