From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbbJNCPJ (ORCPT ); Tue, 13 Oct 2015 22:15:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33760 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750906AbbJNCPF (ORCPT ); Tue, 13 Oct 2015 22:15:05 -0400 Date: Tue, 13 Oct 2015 21:15:02 -0500 From: Andy Gross To: Bjorn Andersson Cc: Georgi Djakov , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: smd-rpm: Correct the active vs sleep state flagging Message-ID: <20151014021502.GA22412@qualcomm.com> References: <1444769863-16190-1-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444769863-16190-1-git-send-email-bjorn.andersson@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 01:57:43PM -0700, Bjorn Andersson wrote: > The BIT() was incorrectly inherited from family A and should not be used > on family B where the state is denoted by an enum. > > Reported-by: Georgi Djakov > Signed-off-by: Bjorn Andersson > --- > drivers/soc/qcom/smd-rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c > index b5feb58dbd9f..2969321e1b09 100644 > --- a/drivers/soc/qcom/smd-rpm.c > +++ b/drivers/soc/qcom/smd-rpm.c > @@ -126,7 +126,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm, > pkt->hdr.length = cpu_to_le32(sizeof(struct qcom_rpm_request) + count); > > pkt->req.msg_id = cpu_to_le32(msg_id++); > - pkt->req.flags = cpu_to_le32(BIT(state)); > + pkt->req.flags = cpu_to_le32(state); Right, nice catch. I'll queue it up. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project