From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752712AbbJNHIV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 03:08:21 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:37876 "EHLO
	mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751930AbbJNHIU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 03:08:20 -0400
Date: Wed, 14 Oct 2015 08:08:16 +0100
From: Lee Jones <lee.jones@linaro.org>
To: "Yang, Fei" <fei.yang@intel.com>
Cc: Borun Fu <borun.fu@linux.intel.com>,
        "sameo@linux.intel.com" <sameo@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
        "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH] mfd: axp20x: Add a cell for the power button part of
 the,axp288 PMICs
Message-ID: <20151014070816.GD32409@x1>
References: <561B5E55.3010802@linux.intel.com>
 <20151013081148.GZ17172@x1>
 <02E7334B1630744CBDC55DA8586225834A6F8C6B@ORSMSX102.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <02E7334B1630744CBDC55DA8586225834A6F8C6B@ORSMSX102.amr.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 13 Oct 2015, Yang, Fei wrote:

> >>  static struct resource axp288_fuel_gauge_resources[] = {
> >>  	{
> >>  		.start = AXP288_IRQ_QWBTU,
> >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >>  		.resources = axp288_fuel_gauge_resources,
> >>  	},
> >>  	{
> >> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >
> >Doesn't this change insinuate that?
> >
> >If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
> 
> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.

I am.

> >> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >> +		.resources = axp288_power_button_resources,
> >> +	},
> >> +	{
> >>  		.name = "axp288_pmic_acpi",
> >>  	},
> >>  };
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog