Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Lee Jones <lee.jones@linaro.org>]

On Wed, 14 Oct 2015, Borun Fu wrote:

> So the patch will be refined to remove the comment as follows. Any
> else comments? 

Please don't top post.  If you have a comment about something that was
said, please make your comment directly _after_ it (a.k.a inline).

> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_fuel_gauge_resources,
>  	},
>  	{
> +		.name = "axp20x-pek",
> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> +		.resources = axp288_power_button_resources,
> +	},
> +	{
>  		.name = "axp288_pmic_acpi",
>  	},
>  };

No need to do this.  It doesn't save anyone any time.

Just resubmit the next version of the patch.

> On 10/14/2015 15:08, Lee Jones wrote:
> > On Tue, 13 Oct 2015, Yang, Fei wrote:
> > 
> >>>>  static struct resource axp288_fuel_gauge_resources[] = {
> >>>>  	{
> >>>>  		.start = AXP288_IRQ_QWBTU,
> >>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >>>>  		.resources = axp288_fuel_gauge_resources,
> >>>>  	},
> >>>>  	{
> >>>> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >>>
> >>> Doesn't this change insinuate that?
> >>>
> >>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
> >>
> >> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
> > 
> > I am.
> > 
> >>>> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >>>> +		.resources = axp288_power_button_resources,
> >>>> +	},
> >>>> +	{
> >>>>  		.name = "axp288_pmic_acpi",
> >>>>  	},
> >>>>  };
> >>
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog