From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbbJNIAK (ORCPT ); Wed, 14 Oct 2015 04:00:10 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38027 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbJNIAH (ORCPT ); Wed, 14 Oct 2015 04:00:07 -0400 Date: Wed, 14 Oct 2015 09:00:03 +0100 From: Lee Jones To: Borun Fu Cc: "Yang, Fei" , "sameo@linux.intel.com" , "linux-kernel@vger.kernel.org" , "Pallala, Ramakrishna" , "jacob.jun.pan@linux.intel.com" Subject: Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs Message-ID: <20151014080003.GF32409@x1> References: <561B5E55.3010802@linux.intel.com> <20151013081148.GZ17172@x1> <02E7334B1630744CBDC55DA8586225834A6F8C6B@ORSMSX102.amr.corp.intel.com> <20151014070816.GD32409@x1> <561E0897.9050500@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <561E0897.9050500@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Oct 2015, Borun Fu wrote: > So the patch will be refined to remove the comment as follows. Any > else comments? Please don't top post. If you have a comment about something that was said, please make your comment directly _after_ it (a.k.a inline). > @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { > .resources = axp288_fuel_gauge_resources, > }, > { > + .name = "axp20x-pek", > + .num_resources = ARRAY_SIZE(axp288_power_button_resources), > + .resources = axp288_power_button_resources, > + }, > + { > .name = "axp288_pmic_acpi", > }, > }; No need to do this. It doesn't save anyone any time. Just resubmit the next version of the patch. > On 10/14/2015 15:08, Lee Jones wrote: > > On Tue, 13 Oct 2015, Yang, Fei wrote: > > > >>>> static struct resource axp288_fuel_gauge_resources[] = { > >>>> { > >>>> .start = AXP288_IRQ_QWBTU, > >>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { > >>>> .resources = axp288_fuel_gauge_resources, > >>>> }, > >>>> { > >>>> + .name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */ > >>> > >>> Doesn't this change insinuate that? > >>> > >>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? > >> > >> Are you suggesting to remove the comment? Just want to make sure I understand you correctly. > > > > I am. > > > >>>> + .num_resources = ARRAY_SIZE(axp288_power_button_resources), > >>>> + .resources = axp288_power_button_resources, > >>>> + }, > >>>> + { > >>>> .name = "axp288_pmic_acpi", > >>>> }, > >>>> }; > >> > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog