From: Sebastian Reichel <sre@kernel.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: tony@atomide.com, wsa@the-dreams.de, pavel@ucw.cz,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Date: Wed, 14 Oct 2015 13:17:02 +0200 [thread overview]
Message-ID: <20151014111702.GA14340@earth> (raw)
In-Reply-To: <20151014105304.GB13084@pali>
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
Hi Pali,
On Wed, Oct 14, 2015 at 12:53:04PM +0200, Pali Rohár wrote:
> On Wednesday 14 October 2015 13:44:16 Roger Quadros wrote:
> > Let's keep the SSI ports disabled in the omap3.dtsi to avoid
> > getting the following noise on the console for boards that don't
> > use the SSI ports.
> >
> > "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
> >
> > As omap3-n900 uses one SSI port, mark it enabled there.
> >
>
> Sebastian, why is second SSI port disabled on N900? It is not used or
> in DTS file are missing some definitions?
Since the second SSI port is not used on the Nokia N900. It's pins
are used for other things, e.g. as GPIO. It's easily verifiable
by checking the mux data:
$ grep -C1 "ssi2_" arch/arm/mach-omap2/mux34xx.c
_OMAP3_MUXENTRY(CAM_D10, 109,
"cam_d10", "ssi2_wake", NULL, NULL,
"gpio_109", "hw_dbg8", NULL, "safe_mode"),
_OMAP3_MUXENTRY(CAM_D2, 101,
"cam_d2", "ssi2_rdy_tx", NULL, NULL,
"gpio_101", "hw_dbg4", NULL, "safe_mode"),
_OMAP3_MUXENTRY(CAM_D3, 102,
"cam_d3", "ssi2_dat_rx", NULL, NULL,
"gpio_102", "hw_dbg5", NULL, "safe_mode"),
_OMAP3_MUXENTRY(CAM_D4, 103,
"cam_d4", "ssi2_flag_rx", NULL, NULL,
"gpio_103", "hw_dbg6", NULL, "safe_mode"),
_OMAP3_MUXENTRY(CAM_D5, 104,
"cam_d5", "ssi2_rdy_rx", NULL, NULL,
"gpio_104", "hw_dbg7", NULL, "safe_mode"),
_OMAP3_MUXENTRY(CAM_HS, 94,
"cam_hs", "ssi2_dat_tx", NULL, NULL,
"gpio_94", "hw_dbg0", NULL, "safe_mode"),
_OMAP3_MUXENTRY(CAM_VS, 95,
"cam_vs", "ssi2_flag_tx", NULL, NULL,
"gpio_95", "hw_dbg1", NULL, "safe_mode"),
At least gpio 104 is already used for resetting the tsc2005.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-14 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 10:44 [PATCH 0/2] omap: hsi: Fix warnings on boards that don't use ssi ports Roger Quadros
2015-10-14 10:44 ` [PATCH 1/2] hsi: omap_ssi_port: Prevent warning if cawake_gpio is not defined Roger Quadros
2015-10-14 11:40 ` Sebastian Reichel
2015-10-14 10:44 ` [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Roger Quadros
2015-10-14 10:53 ` Pali Rohár
2015-10-14 11:17 ` Sebastian Reichel [this message]
2015-10-14 11:19 ` Sebastian Reichel
2015-10-14 11:27 ` Roger Quadros
2015-10-14 11:37 ` Sebastian Reichel
2015-10-14 11:54 ` Roger Quadros
2015-10-19 16:01 ` Tony Lindgren
2015-10-21 8:08 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014111702.GA14340@earth \
--to=sre@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).