From: Sebastian Reichel <sre@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, pavel@ucw.cz, pali.rohar@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Date: Wed, 14 Oct 2015 13:37:36 +0200 [thread overview]
Message-ID: <20151014113736.GC14340@earth> (raw)
In-Reply-To: <561E3C1F.5000406@ti.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
Hi,
On Wed, Oct 14, 2015 at 02:27:27PM +0300, Roger Quadros wrote:
> On 14/10/15 14:19, Sebastian Reichel wrote:
> > On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote:
> >> Let's keep the SSI ports disabled in the omap3.dtsi to avoid
> >> getting the following noise on the console for boards that don't
> >> use the SSI ports.
> >>
> >> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
> >>
> >> As omap3-n900 uses one SSI port, mark it enabled there.
>
> Would it be preferable to disable the ssi-controller node as well in the
> omap3.dtsi file?
If I remember it correctly, existing, but unused IP-Cores
should not be disabled in DT, so that hwmod picks them up
for power management.
Note, that it actually is disabled in omap3.dtsi and then enabled in
omap34xx/omap36xx dts files (the other variants do not have an ssi
module).
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-14 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 10:44 [PATCH 0/2] omap: hsi: Fix warnings on boards that don't use ssi ports Roger Quadros
2015-10-14 10:44 ` [PATCH 1/2] hsi: omap_ssi_port: Prevent warning if cawake_gpio is not defined Roger Quadros
2015-10-14 11:40 ` Sebastian Reichel
2015-10-14 10:44 ` [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Roger Quadros
2015-10-14 10:53 ` Pali Rohár
2015-10-14 11:17 ` Sebastian Reichel
2015-10-14 11:19 ` Sebastian Reichel
2015-10-14 11:27 ` Roger Quadros
2015-10-14 11:37 ` Sebastian Reichel [this message]
2015-10-14 11:54 ` Roger Quadros
2015-10-19 16:01 ` Tony Lindgren
2015-10-21 8:08 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014113736.GC14340@earth \
--to=sre@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).