From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961AbbJNNVM (ORCPT ); Wed, 14 Oct 2015 09:21:12 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:36332 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850AbbJNNVE (ORCPT ); Wed, 14 Oct 2015 09:21:04 -0400 Date: Wed, 14 Oct 2015 14:20:50 +0100 From: Lee Jones To: Mark Brown Cc: Charles Keepax , cw00.choi@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection Message-ID: <20151014132050.GK32409@x1> References: <20151007100017.GB12635@sirena.org.uk> <20151007122642.GH17172@x1> <20151012084554.GB8805@ck-lbox> <20151012134309.GE1542@sirena.org.uk> <20151013080218.GV17172@x1> <20151013151252.GH14956@sirena.org.uk> <20151014072812.GE32409@x1> <20151014094903.GP14956@sirena.org.uk> <20151014123014.GJ32409@x1> <20151014130920.GW14956@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151014130920.GW14956@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Oct 2015, Mark Brown wrote: > On Wed, Oct 14, 2015 at 01:30:14PM +0100, Lee Jones wrote: > > On Wed, 14 Oct 2015, Mark Brown wrote: > > > > > Not necessarily _your_ review. Just someone, other than the > > > > submitter, who I trust and knows about this stuff. You just happen > > > > to tick those boxes this time. Cross pollination and knowledge sharing > > > > is one of the characteristics of MLs which I'm particularly proud of. > > > > That was what it read like. > > ... > > > > So, a more specific question would have helped - just a general "any > > > thoughts" type question isn't very clear. > > > To both comments -- this is how I phrased it: > > > "I either need an Ack from the DT folks, or at least someone who knows > > about this stuff. Mark perhaps." > > I'd have expected something that says why you're looking for this - > something saying what you were unclear on, something more like "It seems > like there's an awful lot of properties for something that just checks > if a jack". From the above (especially with the request for the DT > people to review) it seems like more just a review because there's DT > properties. Your perception is not correct. I always used to ask for a DT review if there are more than a couple being added. These days I'm happy to apply either complex properties, or just ones I'm not 100% on with a suitable Maintainer Ack. That continues to be the case. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog