linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Andrey Konovalov <andreyknvl@google.com>,
	Kostya Serebryany <kcc@google.com>,
	Alexander Potapenko <glider@google.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Borislav Petkov <bp@alien8.de>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	Wolfram Gloger <wmglo@dent.med.uni-muenchen.de>
Subject: Re: [PATCH v2 1/2] Provide READ_ONCE_NOCHECK()
Date: Wed, 14 Oct 2015 15:40:47 +0200	[thread overview]
Message-ID: <20151014134047.GA10316@gmail.com> (raw)
In-Reply-To: <561D31F0.4080106@virtuozzo.com>


* Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:

> 
> 
> On 10/13/2015 07:02 PM, kbuild test robot wrote:
> > Hi Andrey,
> > 
> > [auto build test WARNING on tip/auto-latest -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Andrey-Ryabinin/Provide-READ_ONCE_NOCHECK/20151013-204127
> > config: mn10300-allyesconfig (attached as .config)
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=mn10300 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    fs/nfs/filelayout/filelayout.c: In function 'filelayout_read_pagelist':
> >    fs/nfs/filelayout/filelayout.c:476:2: warning: format '%Zu' expects argument of type 'size_t', but argument 5 has type '__u32' [-Wformat=]
> >      dprintk("--> %s ino %lu pgbase %u req %Zu@%llu\n",
> >      ^
> 
> So the actual warning is here. And it's not new.
> 
> >    In file included from include/linux/nfs_fs.h:28:0,
> >                     from fs/nfs/filelayout/filelayout.c:32:
> >    fs/nfs/filelayout/filelayout.c: In function 'filelayout_write_pagelist':
> >    include/linux/compiler.h:270:8: warning: format '%Zu' expects argument of type 'size_t', but argument 5 has type '__u32' [-Wformat=]
> >      union { typeof(x) __val; char __c[1]; } __u;  \
> >            ^
> >    include/linux/sunrpc/debug.h:33:24: note: in definition of macro 'dfprintk'
> >        printk(KERN_DEFAULT args); \
> >                            ^
> >>> include/linux/compiler.h:274:22: note: in expansion of macro '__READ_ONCE'
> >     #define READ_ONCE(x) __READ_ONCE(x, _check)
> >                          ^
> 
> And this 'note: in expansion of macro' belongs to the warning above.
> So it's a false-positive. 

So if this is a new warning introduced by these patches then the warning needs to 
be addresses - regardless of whether it's a false positive or not.

Thanks,

	Ingo

  reply	other threads:[~2015-10-14 13:41 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 12:35 [PATCH v2 0/2] Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-13 12:35 ` [PATCH v2 1/2] Provide READ_ONCE_NOCHECK() Andrey Ryabinin
2015-10-13 14:16   ` Ingo Molnar
2015-10-13 16:02   ` kbuild test robot
2015-10-13 16:31     ` Andrey Ryabinin
2015-10-14 13:40       ` Ingo Molnar [this message]
2015-10-14 14:11         ` Andrey Ryabinin
2015-10-13 12:35 ` [PATCH v2 2/2] x86/process: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-13 13:48   ` Ingo Molnar
2015-10-13 13:57     ` Andrey Ryabinin
2015-10-13 13:57     ` Dmitry Vyukov
2015-10-13 14:15       ` Andrey Ryabinin
2015-10-13 14:19       ` Ingo Molnar
2015-10-13 15:28 ` [PATCH v3 0/2] " Andrey Ryabinin
2015-10-13 15:28   ` [PATCH v3 1/2] Provide READ_ONCE_NOCHECK() Andrey Ryabinin
2015-10-14 15:28     ` [tip:locking/urgent] compiler, atomics: Provide READ_ONCE_NOCHECK () tip-bot for Andrey Ryabinin
2015-10-14 15:45       ` Paul E. McKenney
2015-10-14 15:50         ` Dmitry Vyukov
2015-10-14 16:01           ` Paul E. McKenney
2015-10-14 16:08             ` Dmitry Vyukov
2015-10-14 16:16               ` Peter Zijlstra
2015-10-14 16:18                 ` Dmitry Vyukov
2015-10-14 16:20                   ` Peter Zijlstra
2015-10-14 16:23                     ` Andy Lutomirski
2015-10-14 16:34                       ` Peter Zijlstra
2015-10-14 17:48                         ` Ingo Molnar
2015-10-14 17:57                           ` Andy Lutomirski
2015-10-14 16:34                     ` Dmitry Vyukov
2015-10-14 16:54                       ` Peter Zijlstra
2015-10-14 16:20               ` Paul E. McKenney
2015-10-14 16:32                 ` Dmitry Vyukov
2015-10-14 17:04                   ` Paul E. McKenney
2015-10-14 17:23                     ` Dmitry Vyukov
2015-10-14 17:34                       ` Paul E. McKenney
2015-10-14 16:19           ` Andrey Ryabinin
2015-10-14 16:29             ` Dmitry Vyukov
2015-10-14 17:06               ` Paul E. McKenney
2015-10-15  9:18     ` linux-next: build problems (Was: [PATCH v3 1/2] Provide READ_ONCE_NOCHECK()) Stephen Rothwell
2015-10-15 10:03       ` Andrey Ryabinin
2015-10-15 10:19       ` [PATCH] compiler, READ_ONCE: Fix build failure with some older GCC Andrey Ryabinin
2015-10-15 11:30         ` Ingo Molnar
2015-10-13 15:28   ` [PATCH v3 2/2] x86/process: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-14 15:29     ` [tip:locking/urgent] x86/mm: Silence KASAN warnings in get_wchan( ) tip-bot for Andrey Ryabinin
2015-10-16  9:44 ` [PATCH v4 0/2] Andrey Ryabinin
2015-10-16  9:44   ` [PATCH v4 1/2] compiler, atomics: Provide READ_ONCE_NOKSAN() Andrey Ryabinin
2015-10-16 10:00     ` Peter Zijlstra
2015-10-16 10:54       ` Andrey Ryabinin
2015-10-16 11:08         ` Peter Zijlstra
2015-10-16 10:33     ` Borislav Petkov
2015-10-16 11:58       ` Andrey Ryabinin
2015-10-18  7:24         ` Ingo Molnar
2015-10-16 16:05       ` Paul E. McKenney
2015-10-16  9:44   ` [PATCH v4 2/2] x86/mm: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-16  9:47   ` [PATCH v4 0/2] " Andrey Ryabinin
2015-10-19  8:37 ` [PATCH v5 " Andrey Ryabinin
2015-10-19  8:37   ` [PATCH v5 1/2] compiler, atomics: Provide READ_ONCE_NOCHECK() Andrey Ryabinin
2015-10-20  9:37     ` [tip:x86/urgent] compiler, atomics, kasan: " tip-bot for Andrey Ryabinin
2015-10-19  8:37   ` [PATCH v5 2/2] x86/mm: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-20  9:37     ` [tip:x86/urgent] x86/mm, kasan: " tip-bot for Andrey Ryabinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014134047.GA10316@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=bp@alien8.de \
    --cc=dvlasenk@redhat.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kbuild-all@01.org \
    --cc=kcc@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=luto@amacapital.net \
    --cc=sasha.levin@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=wmglo@dent.med.uni-muenchen.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).