From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753951AbbJNNm6 (ORCPT ); Wed, 14 Oct 2015 09:42:58 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:34754 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbbJNNm5 (ORCPT ); Wed, 14 Oct 2015 09:42:57 -0400 Date: Wed, 14 Oct 2015 15:42:49 +0200 From: Ingo Molnar To: Aravind Gopalakrishnan Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, dougthompson@xmission.com, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] x86/amd_nb: Rename amd_get_node_id Message-ID: <20151014134249.GB10316@gmail.com> References: <1444742394-3974-1-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444742394-3974-1-git-send-email-Aravind.Gopalakrishnan@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Aravind Gopalakrishnan wrote: > This function doesn't give us the "Node ID" as the function > name suggests. Rather- it receives a PCI device as argument, > checks the available F3 PCI device IDs in the system > and returns the index of the matching Bus/Device IDs > > Renaming it accordingly in this patch. > No functional change is introduced. > > Signed-off-by: Aravind Gopalakrishnan > --- > arch/x86/include/asm/amd_nb.h | 2 +- > drivers/edac/amd64_edac.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/amd_nb.h b/arch/x86/include/asm/amd_nb.h > index 1a5da2e..319843d 100644 > --- a/arch/x86/include/asm/amd_nb.h > +++ b/arch/x86/include/asm/amd_nb.h > @@ -81,7 +81,7 @@ static inline struct amd_northbridge *node_to_amd_nb(int node) > return (node < amd_northbridges.num) ? &amd_northbridges.nb[node] : NULL; > } > > -static inline u16 amd_get_node_id(struct pci_dev *pdev) > +static inline u16 amd_get_node_id_from_pci_dev(struct pci_dev *pdev) So if we go to the trouble of naming things properly, I guess that function should be named: amd_pci_dev_to_node_id() or so. Thanks, Ingo