From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbbJNOpL (ORCPT ); Wed, 14 Oct 2015 10:45:11 -0400 Received: from mga11.intel.com ([192.55.52.93]:9765 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340AbbJNOpH (ORCPT ); Wed, 14 Oct 2015 10:45:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,681,1437462000"; d="scan'208";a="580631703" Date: Wed, 14 Oct 2015 20:18:14 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: nsekhar@ti.com, linux@arm.linux.org.uk, olof@lixom.net, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, tony@atomide.com, r.schwebel@pengutronix.de Subject: Re: [PATCH 10/13] dmaengine: ti-dma-crossbar: Add support for crossbar on AM33xx/AM43xx Message-ID: <20151014144814.GW27370@localhost> References: <1444828344-21378-1-git-send-email-peter.ujfalusi@ti.com> <1444828344-21378-11-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444828344-21378-11-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 04:12:21PM +0300, Peter Ujfalusi wrote: > The DMA event crossbar on AM33xx/AM43xx is different from the one found in > DRA7x family. > Instead of a single event crossbar it has 64 identical mux attached to each > eDMA event line. When the 0 event mux is selected, the default mapped event > is going to be routed to the corresponding eDMA event line. If different > mux is selected, then the selected event is going to be routed to the given > eDMA event. Why is crossbar patch in edma series? > +static void ti_am335x_xbar_free(struct device *dev, void *route_data) > +{ > + struct ti_am335x_xbar_data *xbar = dev_get_drvdata(dev); > + struct ti_am335x_xbar_map *map = route_data; > + > + dev_err(dev, "Unmapping XBAR event %u on channel %u\n", > + map->mux_val, map->dma_line); Err ? -- ~Vinod