From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754022AbbJNPPD (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 11:15:03 -0400
Received: from foss.arm.com ([217.140.101.70]:58994 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752157AbbJNPPB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 11:15:01 -0400
Date: Wed, 14 Oct 2015 16:14:52 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        catalin.marinas@arm.com, will.deacon@arm.com, steve.capper@linaro.org,
        marc.zyngier@arm.com, ard.biesheuvel@linaro.org,
        christoffer.dall@linaro.org
Subject: Re: [PATCHv3 02/11] arm64: Handle section maps for swapper/idmap
Message-ID: <20151014151425.GA5041@leverpostej>
References: <1444821634-1689-1-git-send-email-suzuki.poulose@arm.com>
 <1444821634-1689-3-git-send-email-suzuki.poulose@arm.com>
 <20151014120618.GB2150@leverpostej>
 <561E56D4.40506@arm.com>
 <20151014145158.GA4422@leverpostej>
 <561E6FFB.3020005@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <561E6FFB.3020005@arm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 14, 2015 at 04:08:43PM +0100, Suzuki K. Poulose wrote:
> On 14/10/15 15:51, Mark Rutland wrote:
> >>>>+/* With 4K pages, we use section maps. */
> 
> >>/*
> >>  * ARM64 kernel is guaranteed to be loaded at 2M aligned
> >>  * address (as per booting requirements). Hence we can use
> >>  * section mapping with 4K (section size = 2M) and not with
> >>  * 16K(section size = 32M) or 64K (section size = 512M).
> >>  */
> >
> >That sounds much better. I hadn't figured out why myself, so thanks for
> >the explanation :)
> >
> >However, there's one minor nit: the start of memory below the kernel is
> >2M aligned, but the offset means that the kernel itself is not loaded at
> >a 2M aligned address.
> 
> Oh yes
> 
> >
> >So how about:
> >
> >/*
> >  * The linear mapping and the start of memory are both 2M aligned (per
> >  * the arm64 booting.txt requirements). Hence we can use section mapping
> >  * with 4K (section size = 2M) but not with 16K (section size = 32M) or
> >  * 64K (section size = 512M).
> >  */
> 
> Will add this

Great.

FWIW, with the changes from this thread applied:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.