From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932549AbbJNQuk (ORCPT ); Wed, 14 Oct 2015 12:50:40 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41890 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbbJNQuh (ORCPT ); Wed, 14 Oct 2015 12:50:37 -0400 Date: Wed, 14 Oct 2015 09:50:31 -0700 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Ming Lin , Jens Axboe , Ming Lin , Mike Snitzer , "Martin K. Petersen" , lkml , linux-nvme@lists.infradead.org, Dongsu Park , Kent Overstreet Subject: Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same}B Message-ID: <20151014165031.GA32274@infradead.org> References: <1439363241-31772-1-git-send-email-mlin@kernel.org> <1439363241-31772-6-git-send-email-mlin@kernel.org> <20151013115011.GA6546@infradead.org> <20151014132700.GA19401@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 04:38:50PM +0000, Keith Busch wrote: > I see why the proposal is an improvement, but I don't understand why the > current situation results in a hang. Are we missing some kind of error > recovery in the driver? The driver tries to abort the commands and eventually gets into a death spiral. I'm still trying to understand what exactly is going on.