From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753727AbbJNSFy (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 14:05:54 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:43530 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751533AbbJNSFw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 14:05:52 -0400
Date: Wed, 14 Oct 2015 21:05:41 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Nikhil Rao <nikhil.rao@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] misc: mic/scif: fix wrap around tests
Message-ID: <20151014180541.GO7289@mwanda>
References: <20151009064021.GA7540@mwanda>
 <1444792884.93285.276.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1444792884.93285.276.camel@localhost>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 13, 2015 at 08:21:24PM -0700, Sudeep Dutt wrote:

> > @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t len, off_t offset,
> >  	if ((map_flags & SCIF_MAP_FIXED) &&
> >  	    ((ALIGN(offset, PAGE_SIZE) != offset) ||
> >  	    (offset < 0) ||
> > -	    (offset + (off_t)len < offset)))
> > +	    (len < LONG_MAX - offset)))
> 
> Hi Dan,
> Should this be > instead of < like the others?

Gar.  You're right, obviously.  Thanks.  I will resend tomorrow.

regards,
dan carpenter