From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932750AbbJNSvI (ORCPT ); Wed, 14 Oct 2015 14:51:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36059 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753873AbbJNSvE (ORCPT ); Wed, 14 Oct 2015 14:51:04 -0400 Date: Wed, 14 Oct 2015 11:51:02 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Greg Kroah-Hartman , linaro-kernel@lists.linaro.org, Rafael Wysocki , linux-kernel@vger.kernel.org, arnd@arndb.de, linux-pm@vger.kernel.org, linux@arm.linux.org.uk, stern@rowland.harvard.edu Subject: Re: [PATCH V2] debugfs: Add debugfs_create_ulong() Message-ID: <20151014185102.GI26883@codeaurora.org> References: <3a48d2bb4320bba82f91354d7165c300ef8108bd.1444402709.git.viresh.kumar@linaro.org> <69e3888403d23de9aadf3792be3c0bdce57495b0.1444410517.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69e3888403d23de9aadf3792be3c0bdce57495b0.1444410517.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09, Viresh Kumar wrote: > +struct dentry *debugfs_create_xlong(const char *name, umode_t mode, > + struct dentry *parent, unsigned long *value) > +{ > + return debugfs_create_file(name, mode, parent, value, &fops_xlong); Were you going to refresh this on my debugfs_create_mode() patches? Otherwise the patch looks fine to me. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project