From: Borislav Petkov <bp@alien8.de>
To: Tan Xiaojun <tanxiaojun@huawei.com>
Cc: dougthompson@xmission.com, mchehab@osg.samsung.com,
wuyun.wu@huawei.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 for-next] EDAC: use edac_debugfs_remove_recursive instead of debugfs_remove
Date: Wed, 14 Oct 2015 21:45:01 +0200 [thread overview]
Message-ID: <20151014194501.GF8218@pd.tnic> (raw)
In-Reply-To: <1444787364-104353-1-git-send-email-tanxiaojun@huawei.com>
On Wed, Oct 14, 2015 at 09:49:24AM +0800, Tan Xiaojun wrote:
> debugfs_remove is used to remove a file or an empty directory from
> the debugfs filesystem, but mci->debugfs is not empty.
>
> This is not easily discovered, because debugfs_remove return nothing
> when failed. It can be test like below:
>
> 1)open EDAC config and open CONFIG_EDAC_DEBUG
> 2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/)
> 3)rmmod this module
> 4)we can also see files under /sys/kernel/debug/edac/ like
> "fake_inject"
>
> Reported-by: Yun Wu (Abel) <wuyun.wu@huawei.com>
> Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
Applied,
thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
prev parent reply other threads:[~2015-10-14 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 1:49 [PATCH v2 for-next] EDAC: use edac_debugfs_remove_recursive instead of debugfs_remove Tan Xiaojun
2015-10-14 19:45 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014194501.GF8218@pd.tnic \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=tanxiaojun@huawei.com \
--cc=wuyun.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox