From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754529AbbJNTpJ (ORCPT ); Wed, 14 Oct 2015 15:45:09 -0400 Received: from mail.skyhub.de ([78.46.96.112]:35857 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbbJNTpF (ORCPT ); Wed, 14 Oct 2015 15:45:05 -0400 Date: Wed, 14 Oct 2015 21:45:01 +0200 From: Borislav Petkov To: Tan Xiaojun Cc: dougthompson@xmission.com, mchehab@osg.samsung.com, wuyun.wu@huawei.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 for-next] EDAC: use edac_debugfs_remove_recursive instead of debugfs_remove Message-ID: <20151014194501.GF8218@pd.tnic> References: <1444787364-104353-1-git-send-email-tanxiaojun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1444787364-104353-1-git-send-email-tanxiaojun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 09:49:24AM +0800, Tan Xiaojun wrote: > debugfs_remove is used to remove a file or an empty directory from > the debugfs filesystem, but mci->debugfs is not empty. > > This is not easily discovered, because debugfs_remove return nothing > when failed. It can be test like below: > > 1)open EDAC config and open CONFIG_EDAC_DEBUG > 2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/) > 3)rmmod this module > 4)we can also see files under /sys/kernel/debug/edac/ like > "fake_inject" > > Reported-by: Yun Wu (Abel) > Signed-off-by: Tan Xiaojun Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.