From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754809AbbJOCFB (ORCPT ); Wed, 14 Oct 2015 22:05:01 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33702 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373AbbJOCE6 (ORCPT ); Wed, 14 Oct 2015 22:04:58 -0400 Date: Thu, 15 Oct 2015 11:05:49 +0900 From: Sergey Senozhatsky To: Joonsoo Kim Cc: Andrew Morton , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Herbert Xu , "David S. Miller" , Stephan Mueller , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH v4 8/8] zram: enable contextless compression alg in zram Message-ID: <20151015020549.GE1735@swordfish> References: <1444808304-29320-1-git-send-email-iamjoonsoo.kim@lge.com> <1444808304-29320-9-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444808304-29320-9-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (10/14/15 16:38), Joonsoo Kim wrote: [..] > @@ -352,6 +352,7 @@ static ssize_t comp_algorithm_show(struct device *dev, > size_t sz; > struct zram *zram = dev_to_zram(dev); > > + deprecated_attr_warn("comp_algorithm"); > down_read(&zram->init_lock); > sz = zcomp_available_show(zram->compressor, buf); > up_read(&zram->init_lock); oh, one more thing. deprecated_attr_warn() should come with `Documentation/ABI/obsolete/sysfs-block-zram' update. something like: diff --git a/Documentation/ABI/obsolete/sysfs-block-zram b/Documentation/ABI/obsolete/sysfs-block-zram index 720ea92..ad5b59d 100644 --- a/Documentation/ABI/obsolete/sysfs-block-zram +++ b/Documentation/ABI/obsolete/sysfs-block-zram @@ -117,3 +117,14 @@ Description: Downgraded to write-only node: so it's possible to set new value only; its current value is stored in zram/mm_stat node. + +What: /sys/block/zram/comp_algorithm +Date: XXX +Contact: XXX +Description: + The comp_algorithm file is read/write and provides information + on available, currently selected compression algorithm (read + operation) and lets one to change the compression algorithm + (write operation). + Downgraded to write-only node: use `/proc/crypto' to get the + list of supported compression algorithms. --- And I guess Cc `Jonathan Corbet ' (doc maintainer) and 'linux-api@vger.kernel.org' will be the right thing to do here. -ss