From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754832AbbJOC0i (ORCPT ); Wed, 14 Oct 2015 22:26:38 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34863 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753742AbbJOC0h (ORCPT ); Wed, 14 Oct 2015 22:26:37 -0400 Date: Thu, 15 Oct 2015 11:29:28 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH] zsmalloc: don't test shrinker_enabled in zs_shrinker_count() Message-ID: <20151015022928.GB2840@bbox> References: <1444787879-5428-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444787879-5428-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 10:57:59AM +0900, Sergey Senozhatsky wrote: > We don't let user to disable shrinker in zsmalloc (once > it's been enabled), so no need to check ->shrinker_enabled > in zs_shrinker_count(), at the moment at least. I'm in favor of removing shrinker disable feature with this patch( although we didn't implement it yet) because if there is some problem of compaction, we should reveal and fix it without hiding with the feature. One thing I want is if we decide it, let's remove all things about shrinker_enabled(ie, variable). If we might need it later, we could introduce it easily. Thanks. > > Signed-off-by: Sergey Senozhatsky > --- > mm/zsmalloc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 7ad5e54..8ba247d 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1822,9 +1822,6 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker, > struct zs_pool *pool = container_of(shrinker, struct zs_pool, > shrinker); > > - if (!pool->shrinker_enabled) > - return 0; > - > for (i = zs_size_classes - 1; i >= 0; i--) { > class = pool->size_class[i]; > if (!class) > -- > 2.6.1.134.g4b1fd35 >