From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbbJOGqR (ORCPT ); Thu, 15 Oct 2015 02:46:17 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35105 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbbJOGqP (ORCPT ); Thu, 15 Oct 2015 02:46:15 -0400 Date: Thu, 15 Oct 2015 08:49:09 +0200 From: Daniel Vetter To: Emil Velikov Cc: Mikko Rapeli , linux-api@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel Subject: Re: [PATCH 03/98] drm.h: use __kernel_size_t instead of size_t Message-ID: <20151015064909.GR26718@phenom.ffwll.local> Mail-Followup-To: Emil Velikov , Mikko Rapeli , linux-api@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-4-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 06:19:48PM +0100, Emil Velikov wrote: > On 30 May 2015 at 16:37, Mikko Rapeli wrote: > > Fixes userspace compilation error: > > > > drm/drm.h:132:2: error: unknown type name ‘size_t’ > > > > Signed-off-by: Mikko Rapeli > > --- > > include/uapi/drm/drm.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h > > index ff6ef62..b197650 100644 > > --- a/include/uapi/drm/drm.h > > +++ b/include/uapi/drm/drm.h > > @@ -129,11 +129,11 @@ struct drm_version { > > int version_major; /**< Major version */ > > int version_minor; /**< Minor version */ > > int version_patchlevel; /**< Patch level */ > > - size_t name_len; /**< Length of name buffer */ > > + __kernel_size_t name_len; /**< Length of name buffer */ > > char __user *name; /**< Name of driver */ > > - size_t date_len; /**< Length of date buffer */ > > + __kernel_size_t date_len; /**< Length of date buffer */ > > char __user *date; /**< User-space buffer to hold date */ > > - size_t desc_len; /**< Length of desc buffer */ > > + __kernel_size_t desc_len; /**< Length of desc buffer */ > > char __user *desc; /**< User-space buffer to hold desc */ > > }; > > > > @@ -143,7 +143,7 @@ struct drm_version { > > * \sa drmGetBusid() and drmSetBusId(). > > */ > > struct drm_unique { > > - size_t unique_len; /**< Length of unique */ > > + __kernel_size_t unique_len; /**< Length of unique */ > As the file is used by other platforms than Linux this change will > break them. Can you add a typedef similar to how __u8 and friends are > handled at the top of the file. This file isn't used by anyone else than Linus since years. All of the typedefs can be nuked imo. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch