From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932634AbbJOHMZ (ORCPT ); Thu, 15 Oct 2015 03:12:25 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33349 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbbJOHMY (ORCPT ); Thu, 15 Oct 2015 03:12:24 -0400 Date: Thu, 15 Oct 2015 12:42:18 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Greg Kroah-Hartman , linaro-kernel@lists.linaro.org, Rafael Wysocki , linux-kernel@vger.kernel.org, arnd@arndb.de, linux-pm@vger.kernel.org, linux@arm.linux.org.uk, stern@rowland.harvard.edu Subject: Re: [PATCH V2] debugfs: Add debugfs_create_ulong() Message-ID: <20151015071218.GD19018@linux> References: <3a48d2bb4320bba82f91354d7165c300ef8108bd.1444402709.git.viresh.kumar@linaro.org> <69e3888403d23de9aadf3792be3c0bdce57495b0.1444410517.git.viresh.kumar@linaro.org> <20151014185102.GI26883@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151014185102.GI26883@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-10-15, 11:51, Stephen Boyd wrote: > On 10/09, Viresh Kumar wrote: > > +struct dentry *debugfs_create_xlong(const char *name, umode_t mode, > > + struct dentry *parent, unsigned long *value) > > +{ > > + return debugfs_create_file(name, mode, parent, value, &fops_xlong); > > Were you going to refresh this on my debugfs_create_mode() > patches? Otherwise the patch looks fine to me. I thought you need to refresh your set as I posted this before you have :) -- viresh