Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

Thomas Petazzoni
2015-10-14T21:29:32Z

Hello,

On Wed, 14 Oct 2015 23:44:03 +0200, Rafael J. Wysocki wrote:
> On Wednesday, October 14, 2015 11:10:39 PM Thomas Petazzoni wrote:
> > Rafael,
> >
> > On Wed, 14 Oct 2015 23:28:51 +0200, Rafael J. Wysocki wrote:
> >
> > > > To avoid this confusion, this patch simply deletes the error message.
> > > >
> > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > >
> > > That's only present in linux-next now, right?
> >
> > No, it is already in 4.3-rc since 4.3-rc1. The commit adding the
> > problematic function is 8d4d4e98acd68c31435ebb7beea591dbf60b9eb2, and
> > this function gets used in cpufreq-dt starting at commit
> > 2e02d8723edf6599988852a8ade8f83b2f766cb8.
> >
> > $ git tag --contains 2e02d8723edf6599988852a8ade8f83b2f766cb8
> > v4.3-rc1
> > v4.3-rc2
> > v4.3-rc3
> > v4.3-rc4
> > v4.3-rc5
>
> OK, thanks!
>
> It should carry a
>
> Fixes: 2e02d8723edf
>
> tag then, right?

Yes, I wasn't sure if it really is a fix, and if so, which commit it is
fixing. It is really 8d4d4e98acd68c31435ebb7beea591dbf60b9eb2 that
introduces the confusing message, but the message will not appear until
the newly added function gets used in
2e02d8723edf6599988852a8ade8f83b2f766cb8.

But if 2e02d8723edf6599988852a8ade8f83b2f766cb8 is considered to be the
commit actually introducing the regression, then I'll resubmit an
updated version with the Fixes: tag.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering