Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

Thomas Petazzoni
2015-10-15T07:43:38Z

Viresh, Rafael,

On Thu, 15 Oct 2015 13:05:44 +0530, Viresh Kumar wrote:
> On 14-10-15, 17:52, Thomas Petazzoni wrote:
> > ret = of_init_opp_table(cpu_dev);
> > if (ret) {
> > - pr_err("%s: couldn't find opp table for cpu:%d, %d\n",
> > - __func__, cpu, ret);
> > -
>
> It should have be modified to pr_debug() at least.

Would be fine as well, but then maybe with a rewording:

pr_debug("%s: no static opp table found for cpu %d, assuming one will be added at runtime (%d)\n",
__func__, cpu, ret);

Do you want me to resend a new version? Or a follow-up patch based on
the latest tree from Rafael now that he has applied the previous version?

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering