public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [RFC v2 1/3] migrate: new struct migration and add it to struct page
       [not found] ` <1444900142-1996-2-git-send-email-zhuhui@xiaomi.com>
@ 2015-10-15  9:27   ` Vlastimil Babka
  2015-10-15  9:53     ` Minchan Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Vlastimil Babka @ 2015-10-15  9:27 UTC (permalink / raw)
  To: Hui Zhu, Minchan Kim, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton, Kirill A. Shutemov, Mel Gorman, Dave Hansen,
	Johannes Weiner, Michal Hocko, Konstantin Khlebnikov,
	Andrea Arcangeli, Alexander Duyck, Tejun Heo, Joonsoo Kim,
	Naoya Horiguchi, Jennifer Herbert, Hugh Dickins, Vladimir Davydov,
	David Rientjes, Sasha Levin, Steven Rostedt (Red Hat),
	Aneesh Kumar K.V, Wanpeng Li, Geert Uytterhoeven, Greg Thelen,
	Al Viro, linux-kernel, linux-mm
  Cc: teawater

On 10/15/2015 11:09 AM, Hui Zhu wrote:
> I got that add function interfaces is really not a good idea.
> So I add a new struct migration to put all migration interfaces and add
> this struct to struct page as union of "mapping".

That's better, but not as flexible as the previously proposed approaches 
that Sergey pointed you at:

  http://lkml.iu.edu/hypermail/linux/kernel/1507.0/03233.html
  http://lkml.iu.edu/hypermail/linux/kernel/1508.1/00696.html

There the operations are reachable via mapping, so we can support the 
special operations migration also when mapping is otherwise needed; your 
patch excludes mapping.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC v2 1/3] migrate: new struct migration and add it to struct page
  2015-10-15  9:27   ` [RFC v2 1/3] migrate: new struct migration and add it to struct page Vlastimil Babka
@ 2015-10-15  9:53     ` Minchan Kim
  2015-10-19 12:08       ` Hui Zhu
  0 siblings, 1 reply; 3+ messages in thread
From: Minchan Kim @ 2015-10-15  9:53 UTC (permalink / raw)
  To: Vlastimil Babka
  Cc: Hui Zhu, Nitin Gupta, Sergey Senozhatsky, Andrew Morton,
	Kirill A. Shutemov, Mel Gorman, Dave Hansen, Johannes Weiner,
	Michal Hocko, Konstantin Khlebnikov, Andrea Arcangeli,
	Alexander Duyck, Tejun Heo, Joonsoo Kim, Naoya Horiguchi,
	Jennifer Herbert, Hugh Dickins, Vladimir Davydov, David Rientjes,
	Sasha Levin, Steven Rostedt (Red Hat), Aneesh Kumar K.V,
	Wanpeng Li, Geert Uytterhoeven, Greg Thelen, Al Viro,
	linux-kernel, linux-mm, teawater

On Thu, Oct 15, 2015 at 11:27:15AM +0200, Vlastimil Babka wrote:
> On 10/15/2015 11:09 AM, Hui Zhu wrote:
> >I got that add function interfaces is really not a good idea.
> >So I add a new struct migration to put all migration interfaces and add
> >this struct to struct page as union of "mapping".
> 
> That's better, but not as flexible as the previously proposed
> approaches that Sergey pointed you at:
> 
>  http://lkml.iu.edu/hypermail/linux/kernel/1507.0/03233.html
>  http://lkml.iu.edu/hypermail/linux/kernel/1508.1/00696.html
> 
> There the operations are reachable via mapping, so we can support
> the special operations migration also when mapping is otherwise
> needed; your patch excludes mapping.
> 

Hello Hui,

FYI, I take over the work from Gioh and have a plan to improve the work.
So, Could you wait a bit? Of course, if you have better idea, feel free
to post it.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC v2 1/3] migrate: new struct migration and add it to struct page
  2015-10-15  9:53     ` Minchan Kim
@ 2015-10-19 12:08       ` Hui Zhu
  0 siblings, 0 replies; 3+ messages in thread
From: Hui Zhu @ 2015-10-19 12:08 UTC (permalink / raw)
  To: Minchan Kim
  Cc: Vlastimil Babka, Hui Zhu, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton, Kirill A. Shutemov, Mel Gorman, Dave Hansen,
	Johannes Weiner, Michal Hocko, Konstantin Khlebnikov,
	Andrea Arcangeli, Alexander Duyck, Tejun Heo, Joonsoo Kim,
	Naoya Horiguchi, Jennifer Herbert, Hugh Dickins, Vladimir Davydov,
	David Rientjes, Sasha Levin, Steven Rostedt (Red Hat),
	Aneesh Kumar K.V, Wanpeng Li, Geert Uytterhoeven, Greg Thelen,
	Al Viro, linux-kernel@vger.kernel.org,
	Linux Memory Management List

On Thu, Oct 15, 2015 at 5:53 PM, Minchan Kim <minchan@kernel.org> wrote:
> On Thu, Oct 15, 2015 at 11:27:15AM +0200, Vlastimil Babka wrote:
>> On 10/15/2015 11:09 AM, Hui Zhu wrote:
>> >I got that add function interfaces is really not a good idea.
>> >So I add a new struct migration to put all migration interfaces and add
>> >this struct to struct page as union of "mapping".
>>
>> That's better, but not as flexible as the previously proposed
>> approaches that Sergey pointed you at:
>>
>>  http://lkml.iu.edu/hypermail/linux/kernel/1507.0/03233.html
>>  http://lkml.iu.edu/hypermail/linux/kernel/1508.1/00696.html
>>
>> There the operations are reachable via mapping, so we can support
>> the special operations migration also when mapping is otherwise
>> needed; your patch excludes mapping.
>>
>
> Hello Hui,
>
> FYI, I take over the work from Gioh and have a plan to improve the work.
> So, Could you wait a bit? Of course, if you have better idea, feel free
> to post it.
>
> Thanks.

Hi Minchan and Vlastimil,

If you don't mind. I want to wait the patches and focus on page
movable of zsmalloc part.
What do you think about it?

Best,
Hui

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-19 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1444900142-1996-1-git-send-email-zhuhui@xiaomi.com>
     [not found] ` <1444900142-1996-2-git-send-email-zhuhui@xiaomi.com>
2015-10-15  9:27   ` [RFC v2 1/3] migrate: new struct migration and add it to struct page Vlastimil Babka
2015-10-15  9:53     ` Minchan Kim
2015-10-19 12:08       ` Hui Zhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox