From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751760AbbJOJxo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 05:53:44 -0400
Received: from mail-pa0-f52.google.com ([209.85.220.52]:36762 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750817AbbJOJxn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 05:53:43 -0400
Date: Thu, 15 Oct 2015 18:53:28 +0900
From: Minchan Kim <minchan@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Hui Zhu <zhuhui@xiaomi.com>, Nitin Gupta <ngupta@vflare.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Mel Gorman <mgorman@suse.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.com>,
        Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Alexander Duyck <alexander.h.duyck@redhat.com>,
        Tejun Heo <tj@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Jennifer Herbert <jennifer.herbert@citrix.com>,
        Hugh Dickins <hughd@google.com>,
        Vladimir Davydov <vdavydov@parallels.com>,
        David Rientjes <rientjes@google.com>,
        Sasha Levin <sasha.levin@oracle.com>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Greg Thelen <gthelen@google.com>, Al Viro <viro@zeniv.linux.org.uk>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, teawater@gmail.com
Subject: Re: [RFC v2 1/3] migrate: new struct migration and add it to struct
 page
Message-ID: <20151015095328.GA7001@bgram>
References: <1444900142-1996-1-git-send-email-zhuhui@xiaomi.com>
 <1444900142-1996-2-git-send-email-zhuhui@xiaomi.com>
 <561F7173.3000900@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <561F7173.3000900@suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 15, 2015 at 11:27:15AM +0200, Vlastimil Babka wrote:
> On 10/15/2015 11:09 AM, Hui Zhu wrote:
> >I got that add function interfaces is really not a good idea.
> >So I add a new struct migration to put all migration interfaces and add
> >this struct to struct page as union of "mapping".
> 
> That's better, but not as flexible as the previously proposed
> approaches that Sergey pointed you at:
> 
>  http://lkml.iu.edu/hypermail/linux/kernel/1507.0/03233.html
>  http://lkml.iu.edu/hypermail/linux/kernel/1508.1/00696.html
> 
> There the operations are reachable via mapping, so we can support
> the special operations migration also when mapping is otherwise
> needed; your patch excludes mapping.
> 

Hello Hui,

FYI, I take over the work from Gioh and have a plan to improve the work.
So, Could you wait a bit? Of course, if you have better idea, feel free
to post it.

Thanks.