public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: dinguyen@opensource.altera.com
Cc: tthayer@opensource.altera.com, dinh.linux@gmail.com,
	dougthompson@xmission.com, mchehab@osg.samsung.com,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN
Date: Thu, 15 Oct 2015 11:57:49 +0200	[thread overview]
Message-ID: <20151015095749.GC4267@pd.tnic> (raw)
In-Reply-To: <1444864456-21778-1-git-send-email-dinguyen@opensource.altera.com>

On Wed, Oct 14, 2015 at 06:14:16PM -0500, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling
> ECC_CORR_EN, when error happens, it is the user's responsibility to perform
> a full SDRAM scrub.
> 
> Remove the check for ECC_CORR_EN.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
>  drivers/edac/altera_edac.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
> index 7b64dc7..7a52585 100644
> --- a/drivers/edac/altera_edac.h
> +++ b/drivers/edac/altera_edac.h
> @@ -30,8 +30,7 @@
>  #define CV_CTLCFG_GEN_SB_ERR       0x2000
>  #define CV_CTLCFG_GEN_DB_ERR       0x4000
>  
> -#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN | \
> -				   CV_CTLCFG_ECC_CORR_EN)
> +#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN)
>  
>  /* SDRAM Controller Address Width Register */
>  #define CV_DRAMADDRW_OFST          0x2C
> -- 

Applied,
thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

      reply	other threads:[~2015-10-15  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 23:14 [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN dinguyen
2015-10-15  9:57 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151015095749.GC4267@pd.tnic \
    --to=bp@alien8.de \
    --cc=dinguyen@opensource.altera.com \
    --cc=dinh.linux@gmail.com \
    --cc=dougthompson@xmission.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=tthayer@opensource.altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox