From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbbJOJ54 (ORCPT ); Thu, 15 Oct 2015 05:57:56 -0400 Received: from mail.skyhub.de ([78.46.96.112]:53855 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbJOJ5z (ORCPT ); Thu, 15 Oct 2015 05:57:55 -0400 Date: Thu, 15 Oct 2015 11:57:49 +0200 From: Borislav Petkov To: dinguyen@opensource.altera.com Cc: tthayer@opensource.altera.com, dinh.linux@gmail.com, dougthompson@xmission.com, mchehab@osg.samsung.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN Message-ID: <20151015095749.GC4267@pd.tnic> References: <1444864456-21778-1-git-send-email-dinguyen@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1444864456-21778-1-git-send-email-dinguyen@opensource.altera.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 06:14:16PM -0500, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen > > The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling > ECC_CORR_EN, when error happens, it is the user's responsibility to perform > a full SDRAM scrub. > > Remove the check for ECC_CORR_EN. > > Signed-off-by: Dinh Nguyen > --- > drivers/edac/altera_edac.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h > index 7b64dc7..7a52585 100644 > --- a/drivers/edac/altera_edac.h > +++ b/drivers/edac/altera_edac.h > @@ -30,8 +30,7 @@ > #define CV_CTLCFG_GEN_SB_ERR 0x2000 > #define CV_CTLCFG_GEN_DB_ERR 0x4000 > > -#define CV_CTLCFG_ECC_AUTO_EN (CV_CTLCFG_ECC_EN | \ > - CV_CTLCFG_ECC_CORR_EN) > +#define CV_CTLCFG_ECC_AUTO_EN (CV_CTLCFG_ECC_EN) > > /* SDRAM Controller Address Width Register */ > #define CV_DRAMADDRW_OFST 0x2C > -- Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.