From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753087AbbJOM1n (ORCPT ); Thu, 15 Oct 2015 08:27:43 -0400 Received: from mga09.intel.com ([134.134.136.24]:62255 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923AbbJOM1l (ORCPT ); Thu, 15 Oct 2015 08:27:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,685,1437462000"; d="scan'208";a="827585543" Date: Thu, 15 Oct 2015 15:27:37 +0300 From: Mika Westerberg To: Wolfram Sang Cc: linux-sh@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] i2c: designware-platdrv: enable RuntimePM before registering to the core Message-ID: <20151015122737.GD25691@lahna.fi.intel.com> References: <1444383567-18113-1-git-send-email-wsa@the-dreams.de> <20151015114925.GE1546@katana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151015114925.GE1546@katana> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2015 at 01:49:25PM +0200, Wolfram Sang wrote: > On Fri, Oct 09, 2015 at 10:39:24AM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > The core may register clients attached to this master which may use > > funtionality from the master. So, RuntimePM must be enabled before, otherwise > > this will fail. > > > > Signed-off-by: Wolfram Sang > > No feedback here, but for the other two drivers the same principle was > acked. CCing Mika, just in case. Looks good to me :-) > > Applied to for-current, thanks! > > > --- > > drivers/i2c/busses/i2c-designware-platdrv.c | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > > index 3dd2de31a2f8d3..73d58415bbc100 100644 > > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > > @@ -253,12 +253,6 @@ static int dw_i2c_probe(struct platform_device *pdev) > > adap->dev.parent = &pdev->dev; > > adap->dev.of_node = pdev->dev.of_node; > > > > - r = i2c_add_numbered_adapter(adap); > > - if (r) { > > - dev_err(&pdev->dev, "failure adding adapter\n"); > > - return r; > > - } > > - > > if (dev->pm_runtime_disabled) { > > pm_runtime_forbid(&pdev->dev); > > } else { > > @@ -268,6 +262,13 @@ static int dw_i2c_probe(struct platform_device *pdev) > > pm_runtime_enable(&pdev->dev); > > } > > > > + r = i2c_add_numbered_adapter(adap); > > + if (r) { > > + dev_err(&pdev->dev, "failure adding adapter\n"); > > + pm_runtime_disable(&pdev->dev); > > + return r; > > + } > > + > > return 0; > > } > > > > -- > > 2.1.4 > >