From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbJOM4a (ORCPT ); Thu, 15 Oct 2015 08:56:30 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33281 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbbJOM43 (ORCPT ); Thu, 15 Oct 2015 08:56:29 -0400 Date: Thu, 15 Oct 2015 15:56:12 +0300 From: Dan Carpenter To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, paul.gortmaker@windriver.com, gregkh@linuxfoundation.org, gdonald@gmail.com, cristina.opriceana@gmail.com Subject: Re: [PATCH] staging: rtl8192u: simplify conditional statement Message-ID: <20151015125611.GZ7340@mwanda> References: <1444912394-17664-1-git-send-email-luisbg@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444912394-17664-1-git-send-email-luisbg@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2015 at 01:33:14PM +0100, Luis de Bethencourt wrote: > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index c443e2e..1c2d1a4 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > @@ -466,10 +466,7 @@ void ieee80211_softmac_scan_syncro(struct ieee80211_device *ieee) > /* this prevent excessive time wait when we > * need to wait for a syncro scan to end.. > */ > - if(ieee->state < IEEE80211_LINKED) > - ; > - else > - if (ieee->sync_scan_hurryup) > + if(!ieee->state > IEEE80211_LINKED && ieee->sync_scan_hurryup) The precedence is wrong here. What you wrote is equivalent to: if ((!ieee->state) > IEEE80211_LINKED) goto out; Which can never be true. Also use checkpatch.pl on your patches before sending. regards, dan carpenter