From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbbJORzF (ORCPT ); Thu, 15 Oct 2015 13:55:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36901 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbbJORzD (ORCPT ); Thu, 15 Oct 2015 13:55:03 -0400 Date: Thu, 15 Oct 2015 19:51:36 +0200 From: Oleg Nesterov To: Frederic Weisbecker Cc: Andrew Morton , Rik van Riel , Christoph Lameter , Tejun Heo , Rusty Russell , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/1] kmod: don't run async usermode helper as a child of kworker thread Message-ID: <20151015175136.GA28663@redhat.com> References: <20151014185153.GA8117@redhat.com> <20151015143739.GA20060@redhat.com> <20151015143757.GB20060@redhat.com> <20151015155255.GE12822@lerouge> <20151015163217.GA25118@redhat.com> <20151015165309.GF12822@lerouge> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151015165309.GF12822@lerouge> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15, Frederic Weisbecker wrote: > > On Thu, Oct 15, 2015 at 06:32:17PM +0200, Oleg Nesterov wrote: > > > > But I would like to keep "we do not want to pollute current->children" > > because this the goal of the next cleanups. > > I don't mind it, it's just that it's not obvious _why_ we don't want to > pollute it. Well, this connects to the "Note:" part of the changelog, I don't this the comment can really explain this. But note that this fix is not enough in the long term _unless_ we ensure that another workueue callback can not call kernel_thread() without CLONE_PARENT. And this is what I am going to do. Nevermind, this is (almost) off-topic right now. Please review V2 I'll send in a minute, I tried to update the comment/changelog. Oleg.