From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbbJPA1K (ORCPT ); Thu, 15 Oct 2015 20:27:10 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:61141 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752416AbbJPA1I (ORCPT ); Thu, 15 Oct 2015 20:27:08 -0400 Date: Thu, 15 Oct 2015 20:27:01 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Namhyung Kim , Tom Zanussi , linux-api@vger.kernel.org, Shuah Khan , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] kselftests/ftrace : Add event trigger testcases Message-ID: <20151015202701.752af971@grimm.local.home> In-Reply-To: <55BD4AC5.8040905@hitachi.com> References: <20150725011310.4601.76087.stgit@localhost.localdomain> <20150727093411.GE22022@danjae.kornet> <55BD4AC5.8040905@hitachi.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 02 Aug 2015 07:40:05 +0900 Masami Hiramatsu wrote: > On 2015/07/27 18:34, Namhyung Kim wrote: > > Hi Masami, > > > > On Sat, Jul 25, 2015 at 10:13:10AM +0900, Masami Hiramatsu wrote: > >> This adds simple event trigger testcases for ftracetest, > >> which covers following triggers. > >> - traceon-traceoff trigger > >> - enable/disable_event trigger > >> - snapshot trigger > >> - stacktrace trigger > >> - trigger filters > >> > >> Signed-off-by: Masami Hiramatsu > >> Cc: Steven Rostedt > >> Cc: Ingo Molnar > >> Cc: Shuah Khan > >> Cc: Namhyung Kim > >> Cc: Tom Zanussi > >> --- > >> tools/testing/selftests/ftrace/test.d/functions | 9 +++ > >> .../ftrace/test.d/trigger/trigger-eventonoff.tc | 64 ++++++++++++++++++++ > >> .../ftrace/test.d/trigger/trigger-filter.tc | 59 ++++++++++++++++++ > >> .../ftrace/test.d/trigger/trigger-snapshot.tc | 56 ++++++++++++++++++ > >> .../ftrace/test.d/trigger/trigger-stacktrace.tc | 53 +++++++++++++++++ > >> .../ftrace/test.d/trigger/trigger-traceonoff.tc | 58 ++++++++++++++++++ > >> 6 files changed, 299 insertions(+) > >> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-eventonoff.tc > >> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-filter.tc > >> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-snapshot.tc > >> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-stacktrace.tc > >> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-traceonoff.tc > >> > >> diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions > >> index 5d8cd06..36ca18e 100644 > >> --- a/tools/testing/selftests/ftrace/test.d/functions > >> +++ b/tools/testing/selftests/ftrace/test.d/functions > >> @@ -14,3 +14,12 @@ enable_tracing() { # start trace recording > >> reset_tracer() { # reset the current tracer > >> echo nop > current_tracer > >> } > >> + > >> +reset_trigger() { # reset all current setting triggers > >> + grep -v ^# events/*/*/trigger | > >> + while read line; do > >> + cmd=`echo $line | cut -f2- -d:` > >> + echo "!$cmd" > `echo $line | cut -f1 -d:` > > > > Broken whitespaces? > > Right, I'll fix that. > [..] > > What about checking child_comm too to verify complex filter pattern > > with string type? Maybe something like below (not tested..)? > > > > echo 'traceoff if child_pid != 0 && child_comm ~ '*sh' > events/.../trigger > > OK, I'll add more complex patterns. Hi Masami, Did you ever send an updated patch? -- Steve