From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbbJOWVW (ORCPT ); Thu, 15 Oct 2015 18:21:22 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:39453 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbbJOWVU (ORCPT ); Thu, 15 Oct 2015 18:21:20 -0400 Date: Thu, 15 Oct 2015 18:21:05 -0400 From: Sowmini Varadhan To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-api@vger.kernel.org Subject: Re: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h Message-ID: <20151015222105.GA12132@oracle.com> References: <1444888618-4506-1-git-send-email-mikko.rapeli@iki.fi> <1444888618-4506-24-git-send-email-mikko.rapeli@iki.fi> <20151015110614.GL948@oracle.com> <20151015220025.GG6104@lakka.kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151015220025.GG6104@lakka.kapsi.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (10/16/15 01:00), Mikko Rapeli wrote: > > What kind of portability should exported userspace headers from Linux kernel > need? > > Reviews to my previous changes NACKed usage and > Documentation/CodingStyle chapter 5 says: > > (e) Types safe for use in userspace. > > In certain structures which are visible to userspace, we cannot > require C99 types and cannot use the 'u32' form above. Thus, we > use __u32 and similar types in all structures which are shared > with userspace. Let's be clear: we are not talking about u32 vs __u32, we are talking about uint32_t vs __u32 in your patch. I dont have the context of your "previous changes NACKed.." etc. Why can we not require C99 types in rds.h? Why isnt that a problem for, say, which includes ? --Sowmini