From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbbJPDbw (ORCPT ); Thu, 15 Oct 2015 23:31:52 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41208 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbbJPDbu (ORCPT ); Thu, 15 Oct 2015 23:31:50 -0400 Date: Fri, 16 Oct 2015 05:31:43 +0200 From: Andrew Lunn To: Dinh Nguyen Cc: Florian Fainelli , David Daney , "David S. Miller" , david.daney@cavium.com, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken Message-ID: <20151016033143.GA28207@lunn.ch> References: <561FF9E2.30102@opensource.altera.com> <56200687.9040903@gmail.com> <562005AD.8020903@opensource.altera.com> <56200BD7.8020505@gmail.com> <56200E15.9080603@caviumnetworks.com> <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached > to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when > the call to ksz9021_config_init() is made both of_node and dev->parent->of_node > are NULL, without the patch the dev->parent->of_node is a valid pointer. Thus > the skew values get programmed to the phy. Ah! You have the phy device tree parameters in the wrong place. These are phy paramters, so should really be in the phy node. But socfpga_cyclone5_socdk.dts has them in the MAC node. There is nothing in Documentation/devicetree/bindings/net/micrel.txt which says you are allowed to place them in the MAC node. Obviously the code did allow this, which is what has now broken. Andrew