From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305AbbJPEWN (ORCPT ); Fri, 16 Oct 2015 00:22:13 -0400 Received: from mout.gmx.net ([212.227.17.21]:51077 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbJPEWL (ORCPT ); Fri, 16 Oct 2015 00:22:11 -0400 Date: Fri, 16 Oct 2015 06:21:54 +0200 From: Stefan Lippers-Hollmann To: Thiago Macieira Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Subject: Re: [PATCH 39/39] Update the buildsystem for KConfig finding Qt Message-ID: <20151016062154.6e8bda74@mir> In-Reply-To: <20151016061241.45c51b63@mir> References: <1442946999-37018-1-git-send-email-thiago.macieira@intel.com> <1442946999-37018-40-git-send-email-thiago.macieira@intel.com> <20151016061241.45c51b63@mir> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:mnAyYlop6U5x49WvaQpPtPfneUo6uZHGwny77NoZOfgpSv2ilXy npj4f6CzYc7EbeDbqHCtt3UlZ11Mjk1wl538eUZ7lCPLAQ4J4mNLPQlTTGFKm56nML+qGXJ 6AArkc5Wgabi4HIHy+P7ihStaf0ssZoy4QFiS1yRMVIohEgVogE6855OWTRoonkiBeeLxbU uVJjoJLE03/IIee68Z57Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:1KKIc5N+/Qs=:oUGQtKYxjLDKjqWj7db1cD oOoMGuaKkQHnAkx1QHYd38KECvNnnQqzlriJ1+h8FlHtElk6aHm6qu4LLn19tETuEkm9zvK8+ Kaws0Ukt/tMQz/VORZjD+yrd68PjfbnskVtJV+piwWVvHDQ50Lttc9EYK3e0A7x3GM9u1KjlH D29KoaIMLdZLrh1ZyBNSfByBUdeVzrVGqp/TV1jOfjyU9D1ZvFT7KqfmR5KEk+rOG7hIJaTgY hQX+0s+8hoFwz5LpQI6cASsuHceWGG5koDuqBbmU54agOFGixGGVU8XvN+32pcKDyOCQZ3P46 Eehzuj6+0Fo7qCMArmp4JKlNJ1i9e2/jz6MXRcp7Y6OHWeN6bt0AjslWznloYqTnZB9TIVFj9 MKXNxqEEdAO2wfaPdhRa+KLn46Df0x+R0vU8yLt8UiAG+NUKiHaG+3M36QkE7Ko49NfMAW/aw ZTm1fbP1VFbE5k8S6MWbJX8KbyOZf/b+cSIQde1fsYrpQa3lvW6QEDF8nTfLEVU3EACm1vWst 0ULFs75vNcesEGM/R0+H1Wtkwtt3ITP5srAzovo3TFcaehjdeNoZZvz1SndnIYWMpBndUd/H8 9ZNuxENHHgId0fS9e5RftBuFfAq48DaPSdcumI3P6GYtK8JOPt1durcSBwHLauwZr6jnW6ebQ O5v/HEKv6cwlEkPlSQEtF7bpp0DCsTmUmkdubfU3eslKBHMfl1qPxr5ckvuSVlYr2FePMq6Ms HszPKOmXZu+fLVfgLbP+/BBpnSkue9apJvJ7ro41Yn+0RAXSZStdVtrUSWTaVp4fclwJuK4Zn V9fkv5b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 2015-10-16, Stefan Lippers-Hollmann wrote: > On 2015-09-22, Thiago Macieira wrote: [...] > + QT_SELECT=5 qmake -query QT_VERSION >/dev/null 2>&1 && export QT_SELECT=5 ||: ; \ Apparently this fails if qmake isn't guarded by qtchooser, but the following should work (although I'm still not confident if that would be the best approach): --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -227,6 +227,7 @@ $(obj)/.tmp_qtcheck: $(src)/Makefile # Qt needs some extra effort... $(obj)/.tmp_qtcheck: @set -e; $(kecho) " CHECK qt"; \ + qtchooser --list-versions | grep -q ^5$ && export QT_SELECT=5 ||: ; \ qtver=`qmake -query QT_VERSION` || { \ echo >&2 "*"; \ echo >&2 "* qmake failed."; \ Regards Stefan Lippers-Hollmann