From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Stefan Liebler <stli@linux.vnet.ibm.com>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: futex timeout not working? (bisected)
Date: Fri, 16 Oct 2015 12:31:23 +0200 [thread overview]
Message-ID: <20151016103123.GE4684@osiris> (raw)
In-Reply-To: <alpine.DEB.2.11.1510161218400.3960@nanos>
On Fri, Oct 16, 2015 at 12:21:51PM +0200, Thomas Gleixner wrote:
> Heiko,
>
> On Thu, 15 Oct 2015, Heiko Carstens wrote:
> > /* We wait for half a second. */
> > ts.tv_nsec += 500000000;
> > if (ts.tv_nsec >= 1000000000)
> > {
> > ++ts.tv_sec;
> > ts.tv_nsec -= 1000000000;
> > }
> >
> > ret = syscall (__NR_futex, &futex_word, op, expected, ts, NULL, FUTEX_BITSET_MATCH_ANY);
>
> If you actually hand in a pointer to 'ts' then the program works as
> expected even with the commit in question applied.
Yes, sorry about that! I was just about to write that this should have
been &ts on x86. Since x86 seems to pass also structures >8 bytes by
value.
However on s390 it is passed by reference. So even it I change ts to &ts,
it will hang as I described.
So you are saying this works on x86 and it must be some s390 specific bug?
next prev parent reply other threads:[~2015-10-16 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 10:43 futex timeout not working? (bisected) Heiko Carstens
2015-10-16 10:21 ` Thomas Gleixner
2015-10-16 10:31 ` Heiko Carstens [this message]
2015-10-16 10:33 ` Thomas Gleixner
2015-10-16 10:38 ` Heiko Carstens
2015-10-16 10:35 ` Thomas Gleixner
2015-10-16 10:54 ` Heiko Carstens
2015-10-16 11:50 ` Heiko Carstens
2015-10-16 12:19 ` Thomas Gleixner
2015-10-16 12:45 ` Thomas Gleixner
2015-10-16 13:41 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016103123.GE4684@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=stli@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox