From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbbJPMTW (ORCPT ); Fri, 16 Oct 2015 08:19:22 -0400 Received: from down.free-electrons.com ([37.187.137.238]:60736 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754139AbbJPMTS (ORCPT ); Fri, 16 Oct 2015 08:19:18 -0400 Date: Fri, 16 Oct 2015 14:18:01 +0200 From: Alexandre Belloni To: Gregory CLEMENT Cc: Nicolas Ferre , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: at91/dt: sama5d4: add the macb1 node Message-ID: <20151016121801.GP3421@piout.net> References: <1444997510-8841-1-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444997510-8841-1-git-send-email-gregory.clement@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/10/2015 at 14:11:50 +0200, Gregory CLEMENT wrote : > The second macb is present on all sama5d4 soc. Let's add a node > reflecting it in the device tree. > > Signed-off-by: Gregory CLEMENT > --- > arch/arm/boot/dts/at91-vinco.dts | 5 +---- > arch/arm/boot/dts/sama5d4.dtsi | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-vinco.dts b/arch/arm/boot/dts/at91-vinco.dts > index b8036f5..2215e2e 100644 > --- a/arch/arm/boot/dts/at91-vinco.dts > +++ b/arch/arm/boot/dts/at91-vinco.dts > @@ -82,10 +82,7 @@ > apb { > > adc0: adc@fc034000 { > - /* The vref depends on JP22 of EK. If connect 1-2 then use 3.3V. connect 2-3 use 3.0V */ > - atmel,adc-vref = <3300>; > - /*atmel,adc-ts-wires = <4>;*/ /* Set up ADC touch screen */ > - status = "okay"; /* Enable ADC IIO support */ > + status = "okay"; /* Enable ADC IIO support */ > }; > > mmc0: mmc@f8000000 { This probably shouldn't be part of that patch. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com