From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754216AbbJPNle (ORCPT <rfc822;w@1wt.eu>);
	Fri, 16 Oct 2015 09:41:34 -0400
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:51328 "EHLO
	e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751509AbbJPNld (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 16 Oct 2015 09:41:33 -0400
X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com
X-IBM-MailFrom: heiko.carstens@de.ibm.com
X-IBM-RcptTo: linux-kernel@vger.kernel.org
Date: Fri, 16 Oct 2015 15:41:25 +0200
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Stefan Liebler <stli@linux.vnet.ibm.com>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: futex timeout not working? (bisected)
Message-ID: <20151016134125.GE6354@osiris>
References: <20151015104347.GA4166@osiris>
 <alpine.DEB.2.11.1510161218400.3960@nanos>
 <20151016103123.GE4684@osiris>
 <alpine.DEB.2.11.1510161234340.3960@nanos>
 <20151016105451.GB6354@osiris>
 <20151016115003.GC6354@osiris>
 <alpine.DEB.2.11.1510161416050.4212@nanos>
 <alpine.DEB.2.11.1510161443520.4212@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1510161443520.4212@nanos>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15101613-0021-0000-0000-000007948B9A
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 16, 2015 at 02:45:37PM +0200, Thomas Gleixner wrote:
> The only point I found which does not update the sequence count is
> timekeeping_init().
> 
> Does the patch below fix your issue?
> 

Yes, it does. Thanks for looking into this and fixing it!


> 8<--------------------
> 
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 3739ac6aa473..44d2cc0436f4 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -1251,7 +1251,7 @@ void __init timekeeping_init(void)
>  	set_normalized_timespec64(&tmp, -boot.tv_sec, -boot.tv_nsec);
>  	tk_set_wall_to_mono(tk, tmp);
> 
> -	timekeeping_update(tk, TK_MIRROR);
> +	timekeeping_update(tk, TK_MIRROR | TK_CLOCK_WAS_SET);
> 
>  	write_seqcount_end(&tk_core.seq);
>  	raw_spin_unlock_irqrestore(&timekeeper_lock, flags);
>