From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932746AbbJPRez (ORCPT <rfc822;w@1wt.eu>);
	Fri, 16 Oct 2015 13:34:55 -0400
Received: from mail.skyhub.de ([78.46.96.112]:49140 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754344AbbJPRex (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 16 Oct 2015 13:34:53 -0400
Date: Fri, 16 Oct 2015 19:34:46 +0200
From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Andrew Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [tip:x86/asm] x86/entry/32: Switch INT80 to the new C syscall
 path
Message-ID: <20151016173446.GK31612@pd.tnic>
References: <a7e8d8df96838eae3208dd0441023f3ce7a81831.1444091585.git.luto@kernel.org>
 <tip-150ac78d63afb96360dab448b7b4d33c98c8266c@git.kernel.org>
 <20151015180912.GJ4267@pd.tnic>
 <CALCETrUojEsfNPfNcFFqPJFgJHPbHPXASUy+0vwBfoA1ie_GQA@mail.gmail.com>
 <20151016105229.GF31612@pd.tnic>
 <CALCETrU+-5N5yjpEwYk=wARouXyX-o4W=-JK_7mOhp3A2cFvoQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrU+-5N5yjpEwYk=wARouXyX-o4W=-JK_7mOhp3A2cFvoQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 16, 2015 at 08:59:23AM -0700, Andy Lutomirski wrote:
> Wow I am incompetent.

Bah, it can happen to anyone...

>     set_system_trap_gate(IA32_SYSCALL_VECTOR, entry_INT80_32);
> 
> How did I not catch that in testing?  Can you change that to
> set_system_intr_gate and see if that helps?

Yeah, that was it. Well spotted, thanks!

Reported-and-tested-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.