From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932529AbbJPSuz (ORCPT ); Fri, 16 Oct 2015 14:50:55 -0400 Received: from foss.arm.com ([217.140.101.70]:43010 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932101AbbJPSuy (ORCPT ); Fri, 16 Oct 2015 14:50:54 -0400 Date: Fri, 16 Oct 2015 19:50:48 +0100 From: Mark Rutland To: "Suzuki K. Poulose" Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, marc.zyngier@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, chirstoff.dall@linaro.org, steve.capper@linaro.org, jeremy.linton@arm.com Subject: Re: [PATCHv4 07/12] arm64: Simplify NR_FIX_BTMAPS calculation Message-ID: <20151016185047.GG4039@leverpostej> References: <1445015181-29711-1-git-send-email-suzuki.poulose@arm.com> <1445015181-29711-8-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445015181-29711-8-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16, 2015 at 06:06:16PM +0100, Suzuki K. Poulose wrote: > From: Mark Rutland > > Since NR_FIX_BTMAPS based on the fixed size of 256K, lets use > a formula to derive it for a given page size, rather than defining > for each page size. No need to respin, but I'd prefer the wording: ---- We choose NR_FIX_BTMAPS such that each slot (NR_FIX_BTMAPS * PAGE_SIZE) can address 256K. Use division to derive NR_FIX_BTMAPS rather than defining it for each page size. ---- Thanks for spinning this into a patch! Mark. > > Signed-off-by: Mark Rutland > Signed-off-by: Suzuki K. Poulose > --- > arch/arm64/include/asm/fixmap.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h > index 8b9884c..3097045 100644 > --- a/arch/arm64/include/asm/fixmap.h > +++ b/arch/arm64/include/asm/fixmap.h > @@ -17,6 +17,7 @@ > > #ifndef __ASSEMBLY__ > #include > +#include > #include > #include > > @@ -55,11 +56,7 @@ enum fixed_addresses { > * Temporary boot-time mappings, used by early_ioremap(), > * before ioremap() is functional. > */ > -#ifdef CONFIG_ARM64_64K_PAGES > -#define NR_FIX_BTMAPS 4 > -#else > -#define NR_FIX_BTMAPS 64 > -#endif > +#define NR_FIX_BTMAPS (SZ_256K / PAGE_SIZE) > #define FIX_BTMAPS_SLOTS 7 > #define TOTAL_FIX_BTMAPS (NR_FIX_BTMAPS * FIX_BTMAPS_SLOTS) > > -- > 1.7.9.5 >