linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Will Deacon <will.deacon@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: Q: schedule() and implied barriers on arm64
Date: Fri, 16 Oct 2015 21:06:48 +0200	[thread overview]
Message-ID: <20151016190648.GC3816@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHkRjk7z-bbTx0PyzMP0zqWxmQ4G7RrxydKQgrcigsnQEb0RBg@mail.gmail.com>

On Fri, Oct 16, 2015 at 05:55:35PM +0100, Catalin Marinas wrote:
> arm64 indeed does not have a dmb after spin_lock, it only has a
> load-acquire. So with the default smp_mb__before_spinlock() +
> spin_lock we have:
> 
>   smp_wmb()
>   loop
>     load-acquire
>     store
> 
> So (I think) this guarantees that any writes before wmb+lock would be
> visible before any reads _and_ writes after wmb+lock. However, the
> ordering with reads before wmb+lock is not guaranteed.

That is my understanding as well, and stores could creep up from below
the unlock and then the reads and those stores can cross and you've
lost.

In any case, its all moot now, since Paul no longer requires schedule()
to imply a full barrier.

  parent reply	other threads:[~2015-10-16 19:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 15:18 Q: schedule() and implied barriers on arm64 Peter Zijlstra
2015-10-16 16:04 ` Paul E. McKenney
2015-10-16 16:16   ` Peter Zijlstra
2015-10-16 16:28     ` Paul E. McKenney
2015-10-16 16:39       ` Peter Zijlstra
2015-10-16 16:55     ` Catalin Marinas
2015-10-16 17:28       ` Paul E. McKenney
2015-10-16 19:07         ` Peter Zijlstra
2015-10-16 19:20           ` Paul E. McKenney
2015-10-19 15:18         ` Catalin Marinas
2015-10-16 19:06       ` Peter Zijlstra [this message]
2015-10-19  7:06         ` Ingo Molnar
2015-10-19  9:04           ` Peter Zijlstra
2015-10-19 15:21           ` Catalin Marinas
2015-10-19 16:24             ` Peter Zijlstra
2015-10-20  8:37               ` Ingo Molnar
2015-10-27 16:19               ` Will Deacon
2015-10-27 18:40                 ` Peter Zijlstra
2015-10-28 10:39                   ` Will Deacon
2015-10-16 17:11   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151016190648.GC3816@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).