From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbbJQBpn (ORCPT ); Fri, 16 Oct 2015 21:45:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45024 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbbJQBpm (ORCPT ); Fri, 16 Oct 2015 21:45:42 -0400 Date: Fri, 16 Oct 2015 21:45:34 -0400 From: Sowmini Varadhan To: Santosh Shilimkar Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, ssantosh@kernel.org Subject: Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport Message-ID: <20151017014534.GH5464@oracle.com> References: <1445041610-30133-1-git-send-email-santosh.shilimkar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445041610-30133-1-git-send-email-santosh.shilimkar@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (10/16/15 20:26), Santosh Shilimkar wrote: > > diff --git a/net/rds/send.c b/net/rds/send.c > + if (!test_bit(RDS_LL_SEND_FULL, &conn->c_flags)) > + queue_delayed_work(rds_wq, &conn->c_send_w, 0); A minor note- it would help to add some comments here explaining that the pong has already been added to the sendq earlier.. in the case of IB, if RDS_LL_SEND_FULL has been set, it takes some head-scratching to figure out how the pong gets sent, and a few comments could help clarify that. but other than that, the contents look good to me, thus Acked-by: Sowmini Varadhan