From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbbJQE3O (ORCPT ); Sat, 17 Oct 2015 00:29:14 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:34724 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbbJQE3N (ORCPT ); Sat, 17 Oct 2015 00:29:13 -0400 Date: Sat, 17 Oct 2015 09:59:07 +0530 From: Viresh Kumar To: Saravana Kannan Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, open list Subject: Re: [PATCH V3 5/5] cpufreq: postfix policy directory with the first CPU in related_cpus Message-ID: <20151017042907.GA19018@linux> References: <20151016070842.GY19018@linux> <44a5b86d1df41812461630e5a7c5366d276e2855.1444979341.git.viresh.kumar@linaro.org> <56215512.1080401@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56215512.1080401@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-10-15, 12:50, Saravana Kannan wrote: > In the lines that follow this code we set the > per_cpu(cpufreq_cpu_data) to point to the new policy. But if the > subsequent cpu->get() fails, we goto out_exit_policy. But that label > doesn't clean up the per_cpu(cpufreq_cpu_data). So, I think we need > another label to jump to if ->get() fails We call cpufreq_policy_free() in that case and that does the cleanup you are talking about. -- viresh