From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbbJSCAc (ORCPT ); Sun, 18 Oct 2015 22:00:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52776 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbbJSCAW (ORCPT ); Sun, 18 Oct 2015 22:00:22 -0400 Date: Sun, 18 Oct 2015 19:00:20 -0700 From: Greg KH To: punit vara Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia Lawall , Sudip Mukherjee , Dan Carpenter , Larry Finger Subject: Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Message-ID: <20151019020020.GB8496@kroah.com> References: <1444847155-11243-1-git-send-email-punitvara@gmail.com> <1444847155-11243-5-git-send-email-punitvara@gmail.com> <20151017051635.GA3074@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: > On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: > > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: > >> Put constant on the right side of a test.Problem found using checkpatch: > >> > >> Warning:Comparisons should place the constant on the right side of the test > >> > >> Signed-off-by: Punit Vara > >> --- > >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++-------- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > > > > Didn't apply to my tree :( > In this case what should I do ? Should I do git reset , git pull and > then do changes on latest tree ? That depends on your workflow, how about pulling and then rebase your branch on mine? That's the easiest workflow to use. > One more thing I would like suggestion how can start switching this > driver to LIB80211 ,MAC80211 ? Which is the first file I should focus > ? Simultaneously I am trying to understand the flow of driver . I > would like to know the start point from where I can start doing small > changes. If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily. good luck! greg k-h